Drop aria-labels that duplicate visible text in first-run setup - #475
Merged
Conversation
Follow-up cleanup to #474. Three containers in the welcome/installing steps carried an aria-label equal to their own visible heading, so a screen reader announced each heading twice. Removed the redundant labels (WCAG anti-pattern); the visible headings remain the accessible names. The one non-redundant label (the how-to-play list, whose heading is not shown visually) is kept. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01C9WmcidRL3ABq7qhWHUsrG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up 360 cleanup pass over #474.
Three containers in the first-run welcome and installing steps carried an
aria-labelequal to their own visible heading:<h3>)Each caused a screen reader to announce the heading twice (duplicating visible text in aria-label is a documented anti-pattern). Removed the redundant labels; the visible headings remain the accessible names, and content is announced once.
The one genuinely non-redundant label — the how-to-play ordered list, whose "How to play" heading is not rendered visually — is intentionally kept.
No visual change. tsc clean, eslint unchanged from baseline,
vite buildclean, and FirstRunWizard's 72 tests (including the while-you-wait content assertions) pass.🤖 Generated with Claude Code
https://claude.ai/code/session_01C9WmcidRL3ABq7qhWHUsrG